Checkstyle Results

The following document contains the results of Checkstyle.

Summary

FilesInfos InfosWarnings WarningsErrors Errors
680580

Files

FilesInfosWarningsErrors
edu/internet2/middleware/shibboleth/idp/Version.java010
edu/internet2/middleware/shibboleth/idp/authn/AuthenticationEngine.java020
edu/internet2/middleware/shibboleth/idp/authn/Saml2LoginContext.java010
edu/internet2/middleware/shibboleth/idp/authn/provider/IPAddressLoginHandler.java030
edu/internet2/middleware/shibboleth/idp/authn/provider/UsernamePasswordLoginHandler.java010
edu/internet2/middleware/shibboleth/idp/authn/provider/UsernamePasswordLoginServlet.java010
edu/internet2/middleware/shibboleth/idp/config/profile/ProfileHandlerNamespaceHandler.java040
edu/internet2/middleware/shibboleth/idp/config/profile/SAMLMetadataHandlerBeanDefinitionParser.java020
edu/internet2/middleware/shibboleth/idp/config/profile/StatusHandlerBeanDefinitionParser.java010
edu/internet2/middleware/shibboleth/idp/config/profile/authn/PreviousSessionLoginHandlerBeanDefinitionParser.java010
edu/internet2/middleware/shibboleth/idp/profile/IdPProfileHandlerManager.java020
edu/internet2/middleware/shibboleth/idp/profile/SAMLMetadataProfileHandler.java020
edu/internet2/middleware/shibboleth/idp/profile/saml1/AbstractSAML1ProfileHandler.java040
edu/internet2/middleware/shibboleth/idp/profile/saml1/ArtifactResolution.java010
edu/internet2/middleware/shibboleth/idp/profile/saml1/AttributeQueryProfileHandler.java010
edu/internet2/middleware/shibboleth/idp/profile/saml1/BaseSAML1ProfileRequestContext.java010
edu/internet2/middleware/shibboleth/idp/profile/saml1/ShibbolethSSODecoder.java010
edu/internet2/middleware/shibboleth/idp/profile/saml1/ShibbolethSSOProfileHandler.java020
edu/internet2/middleware/shibboleth/idp/profile/saml2/AbstractSAML2ProfileHandler.java0130
edu/internet2/middleware/shibboleth/idp/profile/saml2/ArtifactResolution.java020
edu/internet2/middleware/shibboleth/idp/profile/saml2/AttributeQueryProfileHandler.java020
edu/internet2/middleware/shibboleth/idp/profile/saml2/BaseSAML2ProfileRequestContext.java010
edu/internet2/middleware/shibboleth/idp/profile/saml2/SSOProfileHandler.java090

Rules

RulesViolationsSeverity
JavadocMethod
  • allowThrowsTagsForSubclasses: "true"
  • allowUndeclaredRTE: "true"
2Warnings Warning
JavadocType0Warnings Warning
JavadocVariable0Warnings Warning
JavadocStyle
  • checkEmptyJavadoc: "true"
0Warnings Warning
ConstantName0Warnings Warning
LocalFinalVariableName0Warnings Warning
LocalVariableName0Warnings Warning
MemberName0Warnings Warning
MethodName0Warnings Warning
PackageName0Warnings Warning
ParameterName0Warnings Warning
StaticVariableName0Warnings Warning
TypeName0Warnings Warning
AvoidStarImport0Warnings Warning
IllegalImport0Warnings Warning
RedundantImport0Warnings Warning
UnusedImports4Warnings Warning
FileLength
  • max: "1000"
0Warnings Warning
LineLength
  • max: "120"
31Warnings Warning
MethodLength
  • max: "50"
8Warnings Warning
ParameterNumber
  • max: "5"
0Warnings Warning
EmptyForIteratorPad0Warnings Warning
MethodParamPad0Warnings Warning
TabCharacter0Warnings Warning
ModifierOrder0Warnings Warning
AvoidNestedBlocks0Warnings Warning
EmptyBlock0Warnings Warning
LeftCurly0Warnings Warning
NeedBraces0Warnings Warning
RightCurly0Warnings Warning
AvoidInlineConditionals0Warnings Warning
DoubleCheckedLocking0Warnings Warning
EmptyStatement0Warnings Warning
EqualsHashCode0Warnings Warning
HiddenField1Warnings Warning
IllegalInstantiation0Warnings Warning
InnerAssignment0Warnings Warning
MissingSwitchDefault0Warnings Warning
RedundantThrows0Warnings Warning
SimplifyBooleanExpression0Warnings Warning
SimplifyBooleanReturn0Warnings Warning
FinalClass0Warnings Warning
HideUtilityClassConstructor1Warnings Warning
InterfaceIsType0Warnings Warning
VisibilityModifier0Warnings Warning
ArrayTypeStyle0Warnings Warning
UpperEll0Warnings Warning
AbstractClassName
  • format: "^Abstract.*$|^Base.*$"
0Warnings Warning
AnonInnerLength0Warnings Warning
EmptyForInitializerPad0Warnings Warning
CovariantEquals0Warnings Warning
DefaultComesLast0Warnings Warning
DeclarationOrder0Warnings Warning
ExplicitInitialization0Warnings Warning
FallThrough0Warnings Warning
IllegalCatch5Warnings Warning
IllegalThrows0Warnings Warning
JUnitTestCase0Warnings Warning
MultipleVariableDeclarations0Warnings Warning
PackageDeclaration0Warnings Warning
ParameterAssignment0Warnings Warning
ReturnCount
  • max: "4"
0Warnings Warning
StringLiteralEquality0Warnings Warning
SuperFinalize0Warnings Warning
ArrayTrailingComma0Warnings Warning
UnnecessaryParentheses0Warnings Warning
MutableException0Warnings Warning
ThrowsCount
  • max: "3"
0Warnings Warning
CyclomaticComplexity6Warnings Warning
TrailingComment0Warnings Warning
PackageHtml
  • fileExtensions: "html"
0Warnings Warning

Details

edu/internet2/middleware/shibboleth/idp/Version.java

ViolationMessageLine
WarningsUtility classes should not have a public or default constructor.20

edu/internet2/middleware/shibboleth/idp/authn/AuthenticationEngine.java

ViolationMessageLine
WarningsLine is longer than 120 characters.154
WarningsLine is longer than 120 characters.736

edu/internet2/middleware/shibboleth/idp/authn/Saml2LoginContext.java

ViolationMessageLine
WarningsCyclomatic Complexity is 13 (max allowed is 10).125

edu/internet2/middleware/shibboleth/idp/authn/provider/IPAddressLoginHandler.java

ViolationMessageLine
Warnings'defaultDeny' hides a field.73
WarningsMissing a Javadoc comment.128
WarningsMissing a Javadoc comment.138

edu/internet2/middleware/shibboleth/idp/authn/provider/UsernamePasswordLoginHandler.java

ViolationMessageLine
WarningsLine is longer than 120 characters.33

edu/internet2/middleware/shibboleth/idp/authn/provider/UsernamePasswordLoginServlet.java

ViolationMessageLine
WarningsCatching 'Throwable' is not allowed.191

edu/internet2/middleware/shibboleth/idp/config/profile/ProfileHandlerNamespaceHandler.java

ViolationMessageLine
WarningsLine is longer than 120 characters.28
WarningsLine is longer than 120 characters.29
WarningsLine is longer than 120 characters.31
WarningsLine is longer than 120 characters.32

edu/internet2/middleware/shibboleth/idp/config/profile/SAMLMetadataHandlerBeanDefinitionParser.java

ViolationMessageLine
WarningsLine is longer than 120 characters.26
WarningsLine is longer than 120 characters.30

edu/internet2/middleware/shibboleth/idp/config/profile/StatusHandlerBeanDefinitionParser.java

ViolationMessageLine
WarningsLine is longer than 120 characters.23

edu/internet2/middleware/shibboleth/idp/config/profile/authn/PreviousSessionLoginHandlerBeanDefinitionParser.java

ViolationMessageLine
WarningsLine is longer than 120 characters.54

edu/internet2/middleware/shibboleth/idp/profile/IdPProfileHandlerManager.java

ViolationMessageLine
WarningsCatching 'Exception' is not allowed.130
WarningsLine is longer than 120 characters.160

edu/internet2/middleware/shibboleth/idp/profile/SAMLMetadataProfileHandler.java

ViolationMessageLine
WarningsCatching 'Exception' is not allowed.62
WarningsCatching 'Exception' is not allowed.84

edu/internet2/middleware/shibboleth/idp/profile/saml1/AbstractSAML1ProfileHandler.java

ViolationMessageLine
WarningsLine is longer than 120 characters.285
WarningsCyclomatic Complexity is 14 (max allowed is 10).579
WarningsMethod length is 75 lines (max allowed is 50).579
WarningsCyclomatic Complexity is 11 (max allowed is 10).705

edu/internet2/middleware/shibboleth/idp/profile/saml1/ArtifactResolution.java

ViolationMessageLine
WarningsLine is longer than 120 characters.202

edu/internet2/middleware/shibboleth/idp/profile/saml1/AttributeQueryProfileHandler.java

ViolationMessageLine
WarningsLine is longer than 120 characters.221

edu/internet2/middleware/shibboleth/idp/profile/saml1/BaseSAML1ProfileRequestContext.java

ViolationMessageLine
WarningsLine is longer than 120 characters.19

edu/internet2/middleware/shibboleth/idp/profile/saml1/ShibbolethSSODecoder.java

ViolationMessageLine
WarningsUnused import - org.opensaml.common.SAMLObject.21

edu/internet2/middleware/shibboleth/idp/profile/saml1/ShibbolethSSOProfileHandler.java

ViolationMessageLine
WarningsLine is longer than 120 characters.339
WarningsLine is longer than 120 characters.354

edu/internet2/middleware/shibboleth/idp/profile/saml2/AbstractSAML2ProfileHandler.java

ViolationMessageLine
WarningsMethod length is 52 lines (max allowed is 50).249
WarningsLine is longer than 120 characters.268
WarningsLine is longer than 120 characters.269
WarningsLine is longer than 120 characters.348
WarningsCyclomatic Complexity is 14 (max allowed is 10).511
WarningsMethod length is 74 lines (max allowed is 50).511
WarningsCyclomatic Complexity is 12 (max allowed is 10).631
WarningsMethod length is 53 lines (max allowed is 50).631
WarningsLine is longer than 120 characters.656
WarningsLine is longer than 120 characters.657
WarningsCyclomatic Complexity is 18 (max allowed is 10).734
WarningsMethod length is 76 lines (max allowed is 50).734
WarningsLine is longer than 120 characters.746

edu/internet2/middleware/shibboleth/idp/profile/saml2/ArtifactResolution.java

ViolationMessageLine
WarningsMethod length is 53 lines (max allowed is 50).89
WarningsLine is longer than 120 characters.227

edu/internet2/middleware/shibboleth/idp/profile/saml2/AttributeQueryProfileHandler.java

ViolationMessageLine
WarningsMethod length is 55 lines (max allowed is 50).73
WarningsLine is longer than 120 characters.223

edu/internet2/middleware/shibboleth/idp/profile/saml2/BaseSAML2ProfileRequestContext.java

ViolationMessageLine
WarningsLine is longer than 120 characters.34

edu/internet2/middleware/shibboleth/idp/profile/saml2/SSOProfileHandler.java

ViolationMessageLine
WarningsUnused import - javax.xml.parsers.DocumentBuilder.26
WarningsUnused import - javax.xml.parsers.DocumentBuilderFactory.27
WarningsUnused import - org.xml.sax.InputSource.66
WarningsMethod length is 61 lines (max allowed is 50).212
WarningsLine is longer than 120 characters.237
WarningsLine is longer than 120 characters.243
WarningsLine is longer than 120 characters.400
WarningsLine is longer than 120 characters.522
WarningsCatching 'Exception' is not allowed.565